IR 5.x Feature Request

e34m5 · Post by **e34m5** » Mon May 03, 2004 3:16 pm

Odd..appeared to work for me..let me know.

Mark Pierson · Post by **Mark Pierson** » Mon May 03, 2004 4:14 pm

See if you can reproduce my results.

Start IR and do a File, New, selecing the 15-2104 remote.

Paste in this device upgrade using the [Add] button:

Upgrade Code 0 = 25 C4 (VCR/1476) GI Cable 0476
C4 08 72 FE 7C 61 B0 70 F0 D0 30 50 C8 98 0C 2C
AC 6C EC 88 CC 1C 9C 5C DC 48 A8
KeyMoves
2A F3 25 C4 1C«Day UP» ¦2B F3 25 C4 9C«Day DOWN
» ¦2C F3 25 C4 5C«Page UP»¦2D F3 25 C4 DC«Page
DOWN»
End

Upon clicking Ok, IR will prompt about assigning "VCR/DVD:1476" to a device button. Select [Yes], and choose CBL/SAT.

The results should be a "VCR/DVD:1476" device with the note "GI Cable 0476". There should also be 4 key moves:

CBL/SAT 1s = CBL/SAT VCR/DVD 1476 $1C 178 Day UP
CBL/SAT 2s = CBL/SAT VCR/DVD 1476 $9C 174 Day DOWN
CBL/SAT 3s = CBL/SAT VCR/DVD 1476 $5C 176 Page UP
CBL/SAT 4s = CBL/SAT VCR/DVD 1476 $DC 172 Page DOWN

Next, [Edit] the device with this code:

Upgrade Code 0 = 25 C4 (VCR/1476) GI Cable 0476 TEST
C4 08 72 FE 4C 61 B0 70 F0 D0 30 50 C8 98 0C 2C
AC 6C EC 88 CC 5C DC 48 A8
KeyMoves
2A F3 25 C4 1C«Day UP/NEXT» ¦2B F3 25 C4 9C«Da
y DOWN/PREV»¦2C F3 25 C4 5C«Page UP»¦2D F3 25 C4
DC«Page DOWN»
End

IR doesn't display any messages. The "VCR/DVD:1476" device is still there with the updated note "GI Cable 0476 TEST", but the key move notes are unchanged:

CBL/SAT 1s = CBL/SAT VCR/DVD 1476 $1C 178 Day UP
CBL/SAT 2s = CBL/SAT VCR/DVD 1476 $9C 174 Day DOWN
CBL/SAT 3s = CBL/SAT VCR/DVD 1476 $5C 176 Page UP
CBL/SAT 4s = CBL/SAT VCR/DVD 1476 $DC 172 Page DOWN

The first 2 key moves have new notes ("Day UP/NEXT" and "Day DOWN/PREV"), but they were not updated.

Lastly, [Edit] the device again using this code:

Upgrade Code 0 = 25 C4 (VCR/1476) GI Cable 0476 TEST
C4 08 72 FE 4C 61 B0 70 F0 D0 30 50 C8 98 0C 2C
AC 6C EC 88 CC 5C DC 48 A8
KeyMoves
2A F3 25 C4 5C«Page UP»¦2B F3 25 C4 DC«Page DOW
N» ¦2C F3 25 C4 1C«Day UP/NEXT» ¦2D F3 25 C4 9C
«Day DOWN/PREV»
End

IR prompts 4 times about "A conflicting Key Move..." (this is the message I was talking about the other day). Answer [Yes] to all 4 prompts. The "VCR/DVD:1476" device is unchanged (as expected), and the key moves have had the hex cmd and EFC updated, but still contain the OLD (now incorrect) notes:

CBL/SAT 1s = CBL/SAT VCR/DVD 1476 $5C 176 Day UP
CBL/SAT 2s = CBL/SAT VCR/DVD 1476 $DC 172 Day DOWN
CBL/SAT 3s = CBL/SAT VCR/DVD 1476 $1C 178 Page UP
CBL/SAT 4s = CBL/SAT VCR/DVD 1476 $9C 174 Page DOWN

I have not tried any other methods of updating yet (like deleting the device and key moves, and/or unassigning the device in the General tab)., but these are not the results I think should be happening in this scenario. If an upgrade is edited, and it contains key moves that are already defined, the NEW key moves (notes and all) should be overwriting the old ones.

e34m5 · Post by **e34m5** » Mon May 03, 2004 7:09 pm

Agreed. Not sure what is happening. I tested that piece and thought it was working.

I'll follow your steps and get it working. Shoul not be a problem. I probably just missed a step along the way in the code.

Nils_Ekberg · Post by **Nils_Ekberg** » Wed May 05, 2004 3:00 pm

It looks like IR jumped to the "conflicting keymove" routine because everything was the same but the button value was different than the existing keymove on the same buttons. After the user decides to accept "YES" the new keymoves to replace the old you may not be going back to the notes routine and only replacing the actual keymove. If the use says "NO" then you just need to trash the new key move and note.

Mark Pierson · Post by **Mark Pierson** » Wed May 05, 2004 3:34 pm

I found another minor problem. If you paste in a device or protocol upgrade that doesn't contain any note (on the header line), IR is inserting a 2 character string of '0x0A 0x20' which is displaying in the notes box as the pipe '|' character, followed by a space.

e34m5 · Post by **e34m5** » Thu May 06, 2004 4:26 pm

I'm out of town for the next few days...won't be able to do anything until the weekend at the earliest....just keep listing the problems and I will fix them

e34m5 · Post by **e34m5** » Mon May 10, 2004 7:00 am

Mark Pierson wrote:I found another minor problem. If you paste in a device or protocol upgrade that doesn't contain any note (on the header line), IR is inserting a 2 character string of '0x0A 0x20' which is displaying in the notes box as the pipe '|' character, followed by a space.

Fixed...minor oversight.

Now on to the bigger issue. Here is what is happening.

The first time the Upgrade is added the KeyMoves have an F in the hibit of the second byte. This indicates to use the default device for the upgrade.

Upon the user selecting to associate this device with CBL/SAT the KeyMoves are then stored as CBL/SAT:...... not as the default upgrade.

Notice than in all the subsequent pastes the F has not changed therefore IR is assuming that these are for KeyMoves with the default device vs the CBL/SAT so that it takes this as new KM's as opposed to revised ones.

I mentioned this in a previuos post but I guess we did not finish that discussion.

So IR at this time has no way of knowing that you are intending to revise the same KM's.

e34m5 · Post by **e34m5** » Mon May 10, 2004 12:33 pm

Ok...I uploaded a new one.

Here is the deal. When you edit and re=paste IR will assume that whatever device you have associated with the setup code is the device you want for the KM's as well. Same as what happens when you first add an Upgrade and IR aks which device you want to use.

Now, having said that I'm not sure that I like doing this automatically. If we don't like this method we may have to ask the user the question for each KM they are trying to re-paste.

Mark Pierson · Post by **Mark Pierson** » Mon May 10, 2004 12:59 pm

e34m5 wrote:Notice than in all the subsequent pastes the F has not changed therefore IR is assuming that these are for KeyMoves with the default device vs the CBL/SAT so that it takes this as new KM's as opposed to revised ones.

I mentioned this in a previuos post but I guess we did not finish that discussion.

So IR at this time has no way of knowing that you are intending to revise the same KM's.

I understand what you're saying, but at some point, IR has to realize it's overwriting an existing key move. The difference between the 1st paste and any subsequent ones is the fact that the upgrade setup code is assigned to a device button (which is why IR doesn't ask again to bind any of the key moves).

That being the case, I think the "new" details (i.e. notes) being pasted in should overwrite anything currently there. Since I can't try your latest version until later tonight, I'm not sure if this is the approach you took or not.

e34m5 · Post by **e34m5** » Mon May 10, 2004 1:07 pm

Mark:

That is the approach I took. An override is just that. Try and see if it works as you imagine it should.

Mark Pierson · Post by **Mark Pierson** » Mon May 10, 2004 5:22 pm

Ok, Paul... everything seems to work the way I think it should (whether or not that's the right way is another matter

).

Those 0x0A 0x20 characters are still showing up in the upgrade and protocol notes when none are pasted in.

e34m5 · Post by **e34m5** » Mon May 10, 2004 5:35 pm

Mark Pierson wrote:Ok, Paul... everything seems to work the way I think it should (whether or not that's the right way is another matter ).

Kewl.... We'll see how people react 8)

Those 0x0A 0x20 characters are still showing up in the upgrade and protocol notes when none are pasted in.

Hmm...Where are you seeing this. In the GUI or in the text file. The problem has to do with the CR/LF that is there even w/o note. I added code to check for that but I guess something else is going on.

Mark Pierson · Post by **Mark Pierson** » Mon May 10, 2004 5:51 pm

e34m5 wrote:Where are you seeing this. In the GUI or in the text file.

They're in both the GUI and the saved file...

e34m5 · Post by **e34m5** » Mon May 10, 2004 6:50 pm

Maybe I don't understand...but I don't see any 0x0A 0x20. When I paste Upgrades/Protocols without notes I don't see anything.

In fact it doesn't save anything to the file since the note is non existent..

I'm not sure how to proceed at this point

Could you post something for me to use in testing perhaps....

Mark Pierson · Post by **Mark Pierson** » Mon May 10, 2004 7:05 pm

I can't really explain this properly, so try this yourself:

Open IR and start a new file.

Paste in a device upgrade with no key moves AND no notes. The Notes window on the Devices tab will show the characters, and they'll be in the saved file as well.

Next, paste in a protocol without notes, and the funky notes in the upgrade disappear, but are in the protocol Notes.

Now, create a key move with a note, and ALL the funky stuff disappears from both the GUI and the saved file.