FIXED:RemoteMaster Support of Comments in Map Files

WagonMaster · Post by **WagonMaster** » Fri Nov 20, 2009 6:18 pm

While testing all the new map/image files with RemoteMaster (RM), I've discovered that it does not appear to support having comments in the map files.

Here's a sample error message from 'rmaster.err' (RM v1.98-beta4):

Code: Select all

Searching for remote with name Dreambox V1 URC-39711
java.lang.NumberFormatException: For input string: "Note"
	at java.lang.NumberFormatException.forInputString(Unknown Source)
	at java.lang.Integer.parseInt(Unknown Source)
	at java.lang.Integer.parseInt(Unknown Source)
	at com.hifiremote.jp1.ImageMap.parse(ImageMap.java:79)
	at com.hifiremote.jp1.Remote.load(Remote.java:282)
	at com.hifiremote.jp1.RemoteManager.findRemoteByName(RemoteManager.java:223)
	at com.hifiremote.jp1.KeyMapMaster.<init>(KeyMapMaster.java:189)
	at com.hifiremote.jp1.RemoteMaster.createAndShowGUI(RemoteMaster.java:1466)
	at com.hifiremote.jp1.RemoteMaster.access$9(RemoteMaster.java:1343)
	at com.hifiremote.jp1.RemoteMaster$5.run(RemoteMaster.java:1507)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

The "Map THIS!" application that is used to create these map files provides a field called "Internal comment about this area:" for every shape being defined. "Map THIS!" essentially creates a map file that looks like this (example from the 'Dreambox-V1.map' file, which generate the error shown above), with a '#'-style comment immediately above the line being commented:

Code: Select all

   .
   .
   .
poly BOUQUET+ 131,206 163,219 164,203 162,191 155,186 146,187 138,194 133,199 131,206 131,206
poly BOUQUET- 130,210 161,224 154,234 144,243 136,244 131,242 127,235 126,224 130,210 130,210
circle MUTE  98,191 115,201
# Note: The 'LAME!'/'ZOOM' button became 'EXIT'/'ZOOM' on later versions.
circle LAME!{ZOOM}  98,215 115,225
circle INFO  43,261 53,272
# The small 'DREAM' button became 'MENU' on later versions.
circle DREAM{small}  158,261 170,273
poly UP 64,264 77,255 90,251 107,251 122,255 135,262 135,267 121,274 110,277 94,278 78,273 68,269 64,264 64,264
poly DOWN 67,327 75,320 87,316 96,314 112,314 124,318 133,324 135,330 121,337 107,340 95,341 83,338 72,334 67,327 67,327
   .
   .
   .

This optional entry is very useful to help explain various things (history, problems, etc) with the buttons being defined. Since it's a built-in part of the "Map THIS!" application, I think RM should support this feature too.

In a pinch, I could remove the comments from the map files (3 currently), but I'd rather not, since they help document the oddities quite nicely and, more importantly, in the most natural place to have them documented.

Any chance of getting these comments supported in the next version of RM?

Bill

gfb107 · Post by **gfb107** » Wed Nov 25, 2009 7:19 pm

gfb107 · Post by **gfb107** » Fri Nov 27, 2009 9:57 am

Try Beta6:

RemoteMaster.v1.98beta6.zip (Windows, Linux 32/64)
RemoteMaster.v1.98beta6.exe (Windows only)

WagonMaster · Post by **WagonMaster** » Sat Nov 28, 2009 1:52 pm

I've now tested with the RM 1.98-beta6 and this problem is gone -- thanks!

I do have the same questions on the source code as mentioned here.

Bill