JP1 Remotes

Barf wrote: Fri May 15, 2026 3:29 am I cannot reproduce the problem I reported, so it appears to have been fixed. Still, I have a bad feeling about the code, as I described in my previous post. Since there are now no known and documented bugs(?), I do not recommend an immediate fix though.

// copy the device parameter values
    if ( base.protocol != null )
    {
      // *DO NOT* call protocol.setDeviceParams() here to clone parmValues!
      // Protocol device params are global state, and may be:
      // - live: currently rendered in the UI; and/or
      // - dirty: containing user-entered input which has not been saved yet.
      //
      // Violation of this rule will result in this code path overwriting
      // user-entered protocol parameters. For example, if the table showing
      // device upgrades is re-rendered while the upgrade dialog is open,
      // the old values in the table data will overwrite any changes the user
      // has typed.
      parmValues = Value.copy( base.parmValues );
//      protocol.setDeviceParms( base.parmValues );
//      parmValues = protocol.getDeviceParmValues();
    }

As I see it, the fundamental problem is that the actual device parameters is present in the Protocol class, where it does not conceptually belong; it belongs to the DeviceUpgrade class.

mathdon wrote: Fri May 15, 2026 4:19 am There are 10 images in this thread, on pages 1 and 2, and all show this "not viewable" message.

Barf wrote: Fri May 15, 2026 4:47 am

mathdon wrote: Fri May 15, 2026 4:19 am There are 10 images in this thread, on pages 1 and 2, and all show this "not viewable" message.

From Germany, they are visible. Then i virtually moved to the UK, using VPN, NordVPN to be exact. And, voilà, now I also get "Content not viewable in your region"!!

So it must be the image hoster, imgur.com, who does not "like" UK.

A workaround is to use VPN.