JP1 Remotes Forum Index JP1 Remotes


FAQFAQ SearchSearch 7 days of topics7 Days MemberlistMemberlist UsergroupsUsergroups RegisterRegister
ProfileProfile Log in to check your private messagesLog in to check your private messages Log inLog in

IrpTransmogrifier: new program/library for IRP protocols
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
 
Post new topic   Reply to topic    JP1 Remotes Forum Index -> JP1 - Software
View previous topic :: View next topic  
Author Message
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Mon Dec 02, 2019 8:54 am    Post subject: Reply with quote

Barf wrote:
mathdon wrote:
... BTW I think this should be an Announcement thread


Rob, can you take care of this? Thanx in advance.

Done.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Thu Dec 05, 2019 9:32 am    Post subject: Change NEC1-f16? Reply with quote

In the light of recent discussion I think it would be a good idea to change the NEC1-f16 definition from
Code:
{38.4k,564}<1,-1|1,-3>(16,-8,D:8,S:8,F:16,1,^108m,(16,-4,1,^108m)*)[D:0..255,S:0..255=255-D,F:0..65535]

to
Code:
{38.4k,564}<1,-1|1,-3>(16,-8,D:8,S:8,F:8,E:8,1,^108m,(16,-4,1,^108m)*)[D:0..255,S:0..255=255-D,F:0..255,E:0..255]

(which is the one DecodeIR presently uses).

Comments?
Back to top
View user's profile Send private message Send e-mail Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Thu Dec 05, 2019 10:04 am    Post subject: Reply with quote

Does that break the long OBC into two smaller OBCs? If so, I agree with the proposal.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
mathdon
Expert


Joined: 22 Jul 2008
Posts: 3283
Location: Cambridge, UK

PostPosted: Thu Dec 05, 2019 2:00 pm    Post subject: Reply with quote

As you wish. I have no preference.
_________________
Graham
Back to top
View user's profile Send private message
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 06, 2019 3:44 am    Post subject: Reply with quote

The Robman wrote:
Does that break the long OBC into two smaller OBCs?

Exactly.

I think there are several advantage of the two byte parameters instead of the one two-byte parameter:

* Compatibility with the standard NEC[1],
* Compatibility with (current) DecodeIR,
* Compatibility with e.g. "Rob's" new Excellist

Probably the old definition was taken at some point of time from DecodeIR, which later changed.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Fri Dec 06, 2019 9:36 am    Post subject: Reply with quote

I have made the update that Bengt suggested to rmProtocols.xml and then re-checked this file to see if it now displays 2 OBCs, but it's still only displaying 1. Are there other changes that need to be made?

Code:
<irp:protocol name="NEC-f16">
        <irp:parameter name="prefer-over">NEC-Shirriff-32</irp:parameter>
   <irp:parameter name="uei-executor">01AD[;D,S,F:8,F:8:8]</irp:parameter>
        <irp:irp><![CDATA[{38.4k,564}<1,-1|1,-3>(16,-8,D:8,S:8,F:8,E:8,1,^108m,(16,-4,1,^108m)*)[D:0..255,S:0..255=255-D,F:0..255,E:0..255]]]></irp:irp>
        <irp:documentation>
            A relaxed form (but used in some real devices) of the <a href="#NEC">NEC</a> protocol. Byte 3 and byte 4 are independent, and display as F and E parameters.
        </irp:documentation>
</irp:protocol>

_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 06, 2019 9:52 am    Post subject: Reply with quote

The Robman wrote:
I have made the update that Bengt suggested to rmProtocols.xml and then re-checked this file to see if it now displays 2 OBCs, but it's still only displaying 1. Are there other changes that need to be made?

There are three protocols really, "NEC-f16", "NEC1-f16", and NEC2-f16"; your changed only the first one. (Have not checked "this file" though.)
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 06, 2019 9:59 am    Post subject: Reply with quote

This is the checked in IrpProtocols.xml with above mentioned changes, as well as Graham's additions..
Back to top
View user's profile Send private message Send e-mail Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Fri Dec 06, 2019 10:07 am    Post subject: Reply with quote

There's only 1 -f16 protocol in that file. I just downloaded IrpProtocols.xml and stored it in my RM folder (i didn't have that file before), but I'm still only seeing 1 long OBC for the -f16 signals in that file.

I just made the corresponding changes to IrpProtocols.html but still no luck.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 06, 2019 10:37 am    Post subject: Reply with quote

The Robman wrote:
There's only 1 -f16 protocol in that file.

There are three. Really.

Quote:
I just downloaded IrpProtocols.xml and stored it in my RM folder (i didn't have that file before),

slightly hairy; you DID have that before, but contained within the jar file RemoteMaster.jar. (A jar file is really nothing else but a zip file with some extra structure.) You can use (I think...) WinZip or WinRar or some such to interactively inspect a jar file, and to replace a file within it. (Or the command line program "jar" from the Java development kit.) Alternatively you can replace Graham's rmProtocols.xml with an alternative IrpProtocols.xml.

Quote:
I just made the corresponding changes to IrpProtocols.html but still no luck.

Not a very good idea: this file is only read by humans, using the browser. It is generated automatically from IrpProtocols.xml during build of IrpTransmogrifier.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Fri Dec 06, 2019 11:03 am    Post subject: Reply with quote

Take a look for yourself, there are 2 regular NEC definitions and 1 F16 definition:
http://www.hifi-remote.com/forums/dload.php?action=file&file_id=25743

Putting IrpProtocols.xml inside remotemaster.jar did the trick, now I get OBC2 displayed as E= in the Misc column. May I suggest adding an OBC2 column in a future release?
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 06, 2019 11:20 am    Post subject: Reply with quote

The Robman wrote:
Take a look for yourself, there are 2 regular NEC definitions and 1 F16 definition:
http://www.hifi-remote.com/forums/dload.php?action=file&file_id=25743


That is Graham's patch file. It modifies some protocols in the present IrpProtocols.xml. What is in there, and not in there, is his decision.

Code:

% irptransmogrifier --regexp list  'NEC.*-f16'
name=NEC-f16
name=NEC1-f16
name=NEC2-f16

Quote:

Putting IrpProtocols.xml inside remotemaster.jar did the trick, now I get OBC2 displayed as E= in the Misc column.

Smile

Quote:
May I suggest adding an OBC2 column in a future release?

That is Graham's decision.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19335
Location: Chicago, IL

PostPosted: Fri Dec 06, 2019 4:14 pm    Post subject: Reply with quote

Lol, I know it's Graham's patch file, but you kept telling me that all 3 versions of f16 were in there and I was trying to show you that it only contains one.

And double lol that I know RMIR is Graham's program, Graham is in this thread too, so I was talking to him.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
mathdon
Expert


Joined: 22 Jul 2008
Posts: 3283
Location: Cambridge, UK

PostPosted: Sun Dec 08, 2019 12:07 pm    Post subject: Reply with quote

The Robman wrote:
May I suggest adding an OBC2 column in a future release?

The single-letter names D, S and F in IRP specifications have been (informally) standardized for Device, Subdevice and Function (OBC) protocol parameters. I don't think E has been standardized for OBC2, which would need to be the case for a new column which was present for all protocols. I would instead prefer to meet the particular case of NEC-f16 by having the E parameter show in the Misc column as OBC2, which I can do for an individual protocol without requiring any standardization of notation. I can even do it with IrpTransmogrifier still using a 16-bit F value, such is the flexibility of the uei-executor entries that link IrpTransmogrifier to RMIR.

The rmProtocols.xml patch file that I posted was a fix specifically for rsbrux and includes only entries for protocols that appear in his Learned Signal decodes. Before it gets added to a development build of RMIR, or incorporated into an IrpTransmogrifier release, I need to investigate what other NEC variants can be represented by the -f16 variants and make further additions to handle those.
_________________
Graham
Back to top
View user's profile Send private message
Barf
Expert


Joined: 24 Oct 2008
Posts: 1008

PostPosted: Fri Dec 20, 2019 1:53 pm    Post subject: Reply with quote

Quote:
Before it gets added to a development build of RMIR, or incorporated into an IrpTransmogrifier release, I need to investigate what other NEC variants can be represented by the -f16 variants and make further additions to handle those.


I intend to release the final 1.2.*-version or IrpTransmogrifier pretty soon, so if Graham (or someone else) wants something particular to go there, please give me an indication.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic       JP1 Remotes Forum Index -> JP1 - Software All times are GMT - 5 Hours
Goto page Previous  1, 2, 3, 4, 5, 6, 7  Next
Page 6 of 7

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


 

Powered by phpBB © 2001, 2005 phpBB Group
Get Smart! the band's official homepage Rockabilly Central