JP1 Remotes Forum Index JP1 Remotes


FAQFAQ SearchSearch 7 days of topics7 Days MemberlistMemberlist UsergroupsUsergroups RegisterRegister
ProfileProfile Log in to check your private messagesLog in to check your private messages Log inLog in

Denon volume control mod
Goto page Previous  1, 2, 3
 
Post new topic   Reply to topic    JP1 Remotes Forum Index -> JP1 - General Forum
View previous topic :: View next topic  
Author Message
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 21210
Location: Chicago, IL

                    
PostPosted: Tue Feb 09, 2021 2:26 pm    Post subject: Reply with quote

Even though the two protocols have similar names, they're actually completely different protocols.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 21210
Location: Chicago, IL

                    
PostPosted: Wed Feb 10, 2021 10:27 am    Post subject: Reply with quote

I just realized that I forgot to copy over the fixed data from the Denon-K upgrade to the manual upgrade, so I just did that, and I changed the protocol id from $00CD to $01CD so it won't clash with your existing upgrade. I also renamed it to amp/1401 for the same reason.

http://www.hifi-remote.com/forums/dload.php?action=file&file_id=26226
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Lurker



Joined: 11 Apr 2004
Posts: 120

                    
PostPosted: Wed Feb 10, 2021 1:07 pm    Post subject: Reply with quote

Thank you! Your new upgrade does control my receiver again, but I don't really notice any difference from Denon-K. I think I found your explanation of what you did years ago:

http://www.hifi-remote.com/forums/viewtopic.php?p=27393#27393

Does this jog your memory? I am comparing your changes to the original Denon-K and it is starting to make sense. But my receiver appears to behave the same either way, so maybe this approach is not going to help?
Back to top
View user's profile Send private message
mathdon
Expert


Joined: 22 Jul 2008
Posts: 4515
Location: Cambridge, UK

                    
PostPosted: Thu Feb 11, 2021 1:25 pm    Post subject: Reply with quote

Let me chip in here. I know little about S3F80 code, so I may be missing something obvious, but I have just looked at Rob's modified protocol in RMPB. There is what I take to be a delay loop labelled L2, but I can't see that it is ever accessed. If a key is held, so repeat is required, the jump at FF28 just loops back to call XmitIR again without an intervening delay. So is the code actually doing what it is supposed to be doing, or not?
_________________
Graham
Back to top
View user's profile Send private message
mathdon
Expert


Joined: 22 Jul 2008
Posts: 4515
Location: Cambridge, UK

                    
PostPosted: Fri Feb 12, 2021 9:56 am    Post subject: Reply with quote

In view of no response to yesterday's post above, I have had a go myself at further modifying Rob's file to make it do what I think it was intended to do. Here is my file. The change is only one byte, to change an RET to an NOP so that after repeats finish, it runs the delay loop to lengthen the lead-out, which I believe was the intention.

I don't know where Rob got his setup functions from, as I can't see that you, Lurker, have posted your original file. Rob changed the protocol to a manual one, which loses the Denon-K interpretation of the function hex. I have changed it back to Denon-K with custom protocol hex so the functions should show with Denon-K interpretation. It is possible I got that back conversion wrong, in which case the functions won't work. Please give it a try and report back.

If you want to see the change, open the file in RMDU and go to Advanced -> Edit protocol. This will display a disassembly of the code. The instruction at FF2A is now NOP and was RET.
_________________
Graham
Back to top
View user's profile Send private message
Lurker



Joined: 11 Apr 2004
Posts: 120

                    
PostPosted: Fri Feb 12, 2021 1:51 pm    Post subject: Reply with quote

Graham, thanks for helping. I tried to test your new file, but I got this error:

Protocol ID conflicts with existing upgrade. To use this built-in protocol, edit the conflicting upgrade to give it an Alternate PID.

I am unable to enter an Alternate PID in either upgrade. Your upgrade says: PID in use, Alt PID not available. The conflicting upgrade has no place to enter an Alternate PID.

Denon-K is 00 CD. The conflicting upgrade uses Panasonic Combo, which is also 00 CD. Should two different protocols have the same PID? Or are they actually the same protocol with two names?

Unable to proceed, I instead went back to Rob's file and changed the one instruction like you did. I must have done something wrong because my receiver doesn't respond at all, BUT I can see that it is going much slower, one press lights up for around a full second.

So, your change does make a big difference. Now I need to figure out what I did wrong, or figure out the conflicting PIDs, before I can proceed.
Back to top
View user's profile Send private message
mathdon
Expert


Joined: 22 Jul 2008
Posts: 4515
Location: Cambridge, UK

                    
PostPosted: Fri Feb 12, 2021 2:26 pm    Post subject: right Reply with quote

Ah, so that is why Rob changed the PID. They ARE the same protocol code before the mod, so it is right that they have the same PID, but we are changing one byte for one of the two protocols only, so causing the conflict.

You can resolve this by doing the same thing that Rob did. Open my file in RMDU and on the Setup tab press the button "Convert to Manual". You then get an Alternate PID box in which you can enter 01 CD, then press the Enter key (or navigate away from that box). What you have entered in the box will disappear but the Protocol ID box will show the new value. You can then save it (give the .rmdu file a new name, though) and that should avoid the conflict.

The disadvantage of converting to manual is that the OBC values in the Functions tab get messed up, but their hex code is unchanged so it should still work. There is no guarantee that my fix will work, but I am prepared to work with you to try to make it if it does not. If it does work, I can fix the conflict and have the Functions tab displaying properly, but let us first try to get it working.
_________________
Graham
Back to top
View user's profile Send private message
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 21210
Location: Chicago, IL

                    
PostPosted: Fri Feb 12, 2021 5:52 pm    Post subject: Reply with quote

I haven't been ignoring this thread, it's just that during the work week I don't have much time.

What I did with my upgrade was this:
1. Look at the old modified Denon code in PB to see what the changes were.
2. Make a copy of the Denon-K code in PB and try to do the same changes.
3. Name the new protocol $01CD so as not to clash with $00CD that is already being used by Lurker.
4. Start an upgrade using KM's Manual Settings, then open it using RM.
5. Copy the hex code for the Functions from Lurker's upgrade over to RM.
6. Copy the button assignments over to the new RM also.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 21210
Location: Chicago, IL

                    
PostPosted: Fri Feb 12, 2021 7:04 pm    Post subject: Reply with quote

Ok, I just had a chance to look at my code and Graham's right, it was pretty much doing what the regular Denon-K code would do. The original modified Denon code from this thread was trying to send repeats in groups of 5, to achieve certain volume increments, though I don't know that that's needed here for the Denon-K upgrade. So, I just modified the code so that it has a really long leadout time, which should have the effect of really slowing down how fast the volume goes up or down when you hold the button. I suspect that it will be too slow, but it's somewhere to start, so replace the protocol code with the code below. (Remember, you just need to copy/paste the hex code, you don't need to first or last lines).

Upgrade protocol 0 = 01 CD (S3C8+) Denon-K custom (PB v4.02)
45 91 32 8B 12 8F 44 08 08 00 DA 00 C6 00 DA 02
7B 90 C9 06 D0 03 54 E4 05 08 B4 06 08 B4 07 08
20 11 F6 01 46 C6 F8 FF FF F6 01 58 F6 01 0A 7B
F1 AF
End
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Lurker



Joined: 11 Apr 2004
Posts: 120

                    
PostPosted: Thu Feb 25, 2021 3:02 pm    Post subject: Reply with quote

Rob, your latest protocol still didn't really help. However, during all my testing, I came up with a simpler solution that does help.

Instead of a custom protocol, I put a macro on the volume keys which sends the key 4 times. This seems to be interpreted as one key held down for a short time, which always results in a 4.5dB change (instead of 0.5dB), and this works really well.

Thanks again to Rob and Graham for helping me. I probably would not have thought of this solution without working though the problem with both of you.
Back to top
View user's profile Send private message
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 21210
Location: Chicago, IL

                    
PostPosted: Thu Feb 25, 2021 3:40 pm    Post subject: Reply with quote

So that sounds like you don't need a long leadout, which is what I was trying to space out the repeats, it looks like you need them in groups of 4. The original executor was sending them in groups of 5.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Lurker



Joined: 11 Apr 2004
Posts: 120

                    
PostPosted: Fri Feb 26, 2021 9:51 am    Post subject: Reply with quote

Yes, you are right! I tried 5 in my macro, and it was way too much. 4 was just right. This seems to be the threshold where the ridiculous warp speed change begins.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic       JP1 Remotes Forum Index -> JP1 - General Forum All times are GMT - 5 Hours
Goto page Previous  1, 2, 3
Page 3 of 3

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


 

Powered by phpBB © 2001, 2005 phpBB Group
Top 7 Advantages of Playing Online Slots The Evolution of Remote Control